Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor flags on apps and apis commands [CLI-69] #165

Merged
merged 4 commits into from
Mar 15, 2021
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Mar 15, 2021

Description

This command encapsulates and extracts the repetitive logic to define, register, configure and prompt for the value of string slice flags on apps and apis commands.

  • Each flag is defined once in a struct instance that acts as a single source of truth for all the commands of a given resource
  • The prompt logic is abstracted away
  • The flag registration and configuration logic is abstracted away

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@Widcket Widcket requested review from cyx and jfatta March 15, 2021 21:16
@Widcket Widcket merged commit 9c144d3 into main Mar 15, 2021
@Widcket Widcket deleted the refactor-flags branch March 15, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants